proper reporting of rust version based on git commit hash - build-info#123
Merged
stephen-derosa merged 3 commits intoMay 13, 2026
Merged
Conversation
stephen-derosa
requested review from
alan-george-lk and
xianshijing-lk
as code owners
stephen-derosa
force-pushed
the
sderosa/BOT-348-ffi-lib-reporting
branch
2 times, most recently
from
7de6a21 to
93c8e84
Compare
alan-george-lk
approved these changes
May 12, 2026
ladvoc
reviewed
May 12, 2026
stephen-derosa
force-pushed
the
sderosa/BOT-348-ffi-lib-reporting
branch
from
9d7abc5 to
cb091f6
Compare
xianshijing-lk
approved these changes
May 12, 2026
stephen-derosa
force-pushed
the
sderosa/BOT-348-ffi-lib-reporting
branch
from
cb091f6 to
b44929b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Fixes C++ SDK version reporting by sending the release version (LIVEKIT_BUILD_VERSION) to the Rust FFI instead of the build-flavored value (LIVEKIT_BUILD_VERSION_FULL, e.g. 1.2.3-release).
Also adds release provenance metadata to SDK bundles via share/livekit/build-info.json, recording the C++ SDK version, C++ commit, Rust submodule commit, and bundled livekit-ffi crate version. Release CI now validates that bundled artifacts include the expected version metadata and do not fall back to 0.0.0.
Validation:
Added a C++ unit test to ensure the server-facing version does not include -debug / -release.
Verified locally with ./build.sh release --version 1.2.3-rc1 --bundle --prefix sdk-out/build-info-smoke. The installed bundle contains share/livekit/build-info.json, preserves the full prerelease SDK version, emits UTC ISO-8601 build_date, and matches include/livekit/build.h.
BOT-348
Related MR